Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: correct DataStream fields. #401

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix: correct DataStream fields. #401

merged 2 commits into from
Jul 11, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 10, 2024

Description

Correct DataStream fields which returns a differently capitalized health status and doesn't always return all fields.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock force-pushed the fix-data-streams branch from 7035881 to f7fcb90 Compare July 10, 2024 21:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

Changes Analysis

Commit SHA: 1171731
Comparing To SHA: 1a73935

API Changes

Summary


└─┬Components
  ├──[➕] schemas (26499:7)
  ├─┬indices._common:DataStream
  │ ├──[➖] required (41623:11)❌ 
  │ ├──[➖] required (41621:11)❌ 
  │ ├──[➖] required (41622:11)❌ 
  │ └─┬status
  │   └──[🔀] $ref (26499:13)❌ 
  ├─┬indices._common:IndexTemplate
  │ └──[➖] required (42116:11)❌ 
  └─┬indices._common:DataStreamIndex
    ├──[➖] required (41646:11)❌ 
    └──[➖] required (41647:11)❌
Document Element Total Changes Breaking Changes
components 8 7
  • ❌ BREAKING Changes: 7 out of 8
  • Modifications: 1
  • Removals: 6
  • Additions: 1
  • Breaking Removals: 6
  • Breaking Modifications: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9898854113/artifacts/1692937604

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock force-pushed the fix-data-streams branch from f7fcb90 to 316a995 Compare July 11, 2024 03:36
@dblock dblock force-pushed the fix-data-streams branch from f9e3404 to 1171731 Compare July 11, 2024 21:37
@nhtruong nhtruong merged commit 026abe9 into opensearch-project:main Jul 11, 2024
10 checks passed
@dblock dblock deleted the fix-data-streams branch July 11, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhtruong nhtruong nhtruong approved these changes

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@Xtansia Xtansia Awaiting requested review from Xtansia Xtansia is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@Tokesh Tokesh Awaiting requested review from Tokesh Tokesh is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblock @nhtruong